[webkit-reviews] review denied: [Bug 101929] Web Inspector: Sources: Scope Variables: add "Add to watch" menu item. : [Attachment 194806] Add to watch for scope variables

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied  review:
Bug 101929: Web Inspector: Sources: Scope Variables: add "Add to watch" menu
item.
https://bugs.webkit.org/show_bug.cgi?id=101929

Attachment 194806: Add to watch for scope variables
https://bugs.webkit.org/attachment.cgi?id=194806&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194806&action=review


> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:487
> +		   internalProperties[i].internal = true;

I'm fine with having 'internal' marker on properties but I'd like it to be
determined at the construction time of the property. For this particular place
I think 'internal' property should be set in
RemoteObject.prototype._getProperties - in the handler of the protocol response
where we already have separate lists of properties and internalProperties.