[webkit-reviews] review granted: [Bug 113145] HandleSet should use HeapBlocks for storing handles : [Attachment 194731] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 113145: HandleSet should use HeapBlocks for storing handles
https://bugs.webkit.org/show_bug.cgi?id=113145

Attachment 194731: Patch
https://bugs.webkit.org/attachment.cgi?id=194731&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194731&action=review


r=me

> Source/JavaScriptCore/heap/HandleBlockInlines.h:53
> +    return reinterpret_cast<char*>(this) + ((sizeof(HandleBlock) + 7) & ~7);


Let's use roundUpToMultipleOf<sizeof(double)>() here, to make it a little less
mysterious.