[webkit-reviews] review denied: [Bug 112641] It should be possible to assign null to MediaElement.controller : [Attachment 194656] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Steve Block
<steveblock at chromium.org>'s request for review:
Bug 112641: It should be possible to assign null to MediaElement.controller
https://bugs.webkit.org/show_bug.cgi?id=112641

Attachment 194656: Patch
https://bugs.webkit.org/attachment.cgi?id=194656&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
> I think the JSC bindings are wrong, as assigning the wrong type to the
controller attribute should throw. I'm new to this code, but have filed Bug
113120 to look into this (though it's currently blocked on a bug with the
existing tests).

Would it be possible to fix both JSC and V8 consistently in this patch? It
looks like that your patch fixes one inconsistency but introduces another
inconsistency (i.e. Only V8 binding treats IsNull() specially).

BTW, why do you want to treat only null specially? What about undefined? I'd be
happy if you could point to the spec.