[webkit-reviews] review granted: [Bug 113099] EWS should use a human readable port name when uploading layout test archives : [Attachment 194632] Fixes the bug

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 113099: EWS should use a human readable port name when uploading layout
test archives
https://bugs.webkit.org/show_bug.cgi?id=113099

Attachment 194632: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=194632&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194632&action=review


>> Tools/Scripts/webkitpy/tool/bot/botinfo.py:34
>> +	    self._port_name = port_name
> 
> Kinda lame that it can't get this off the tool, but I tool doesn't have a
modern Port object yet?  dpranke would know.  There is some dependency
inversion currently as the modern "Port" object is also the "host" god-object
for the layout_tests sub-system.  Host was created to solve this, but the
dependncy has yet to be righted yet iirc.

I thought I had added one at some point, but I guess not.