[webkit-reviews] review granted: [Bug 112359] Check WEBGL_draw_buffers requirements before exposing the extension : [Attachment 194393] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 112359: Check WEBGL_draw_buffers requirements before exposing the extension
https://bugs.webkit.org/show_bug.cgi?id=112359

Attachment 194393: Patch
https://bugs.webkit.org/attachment.cgi?id=194393&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194393&action=review


Thanks for the updates. Looks good.

> Source/WebCore/html/canvas/EXTDrawBuffers.cpp:150
> +	   context->framebufferTexture2D(GraphicsContext3D::FRAMEBUFFER,
GraphicsContext3D::STENCIL_ATTACHMENT, GraphicsContext3D::TEXTURE_2D, 0, 0);

Strictly speaking it isn't necessary to touch the DEPTH and STENCIL attachments
here any more.

> Source/WebCore/html/canvas/EXTDrawBuffers.cpp:165
> +	       context->framebufferTexture2D(GraphicsContext3D::FRAMEBUFFER,
GraphicsContext3D::STENCIL_ATTACHMENT, GraphicsContext3D::TEXTURE_2D,
depthStencil, 0);

OK, I see your point that WebGLRenderingContext implements
DEPTH_STENCIL_ATTACHMENT as two separate attachments at the GC3D level.