[webkit-reviews] review granted: [Bug 113104] Dashboard refactor: Move cross dashboard history related code into history.js. : [Attachment 194640] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Julie Parent <jparent at google.com>'s
request for review:
Bug 113104: Dashboard refactor: Move cross dashboard history related code into
history.js.
https://bugs.webkit.org/show_bug.cgi?id=113104

Attachment 194640: Patch
https://bugs.webkit.org/attachment.cgi?id=194640&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194640&action=review


> Tools/TestResultServer/static-dashboards/history.js:112
> +  this.crossDashboardState = {};
> +  this.dashboardSpecificState = {};

I think we eventually want to find a way to make these private as well. Only
the History object should know about cross-dashboard vs. dashboard specific
parameters. But, that's probably easier to do once the rest of this cleanup is
further along.

> Tools/TestResultServer/static-dashboards/history.js:126
> +    parseCrossDashboardParameters: function()

We can make this private eventually too?