[webkit-reviews] review granted: [Bug 113003] Remove 2 bad branches from StringHash::equal() and CaseFoldingHash::equal() : [Attachment 194645] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 22 16:23:32 PDT 2013


Eric Seidel <eric at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 113003: Remove 2 bad branches from StringHash::equal() and
CaseFoldingHash::equal()
https://bugs.webkit.org/show_bug.cgi?id=113003

Attachment 194645: Patch
https://bugs.webkit.org/attachment.cgi?id=194645&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194645&action=review


LGTM!

> Source/WebCore/html/parser/HTMLTreeBuilderSimulator.cpp:98
> +    return equalIgnoringCase(token.data().asStringImpl(),
SVGNames::foreignObjectTag.localName().impl());

These are known to never be null, btw.


More information about the webkit-reviews mailing list