[webkit-reviews] review granted: [Bug 113079] Enable canvas.getContext("webgl") on Desktop Chrome : [Attachment 194642] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 22 15:49:28 PDT 2013


Dean Jackson <dino at apple.com> has granted Brandon Jones
<bajones at chromium.org>'s request for review:
Bug 113079: Enable canvas.getContext("webgl") on Desktop Chrome
https://bugs.webkit.org/show_bug.cgi?id=113079

Attachment 194642: Patch
https://bugs.webkit.org/attachment.cgi?id=194642&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194642&action=review


Ha! I'm pretty sure what's good enough for Ken is good enough for me.

> LayoutTests/fast/canvas/webgl/wegl-unprefixed-context-id.html:17
> +if (!gl) {
> +  testFailed("context does not exist");
> +} else {
> +  testPassed("context exists");
> +}

Single line conditional {} style warning.


More information about the webkit-reviews mailing list