[webkit-reviews] review granted: [Bug 113006] After switching to another space and back, video races to catch up with audio : [Attachment 194452] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 113006: After switching to another space and back, video races to catch up
with audio
https://bugs.webkit.org/show_bug.cgi?id=113006

Attachment 194452: Patch
https://bugs.webkit.org/attachment.cgi?id=194452&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194452&action=review


> Source/WebKit2/UIProcess/API/mac/WKView.mm:284
> +    NSNotificationCenter* nc = [[NSWorkspace sharedWorkspace]
notificationCenter];

Please use a more descriptive variable name here, like
workspaceNotificationCenter.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3173
> +    [nc addObserver:self selector:@selector(_activeSpaceDidChange:)
name:NSWorkspaceActiveSpaceDidChangeNotification object:nil];

Ditto.