[webkit-reviews] review denied: [Bug 79273] HTML Comments after </body> are placed at the bottom of the <body> contents : [Attachment 194545] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 22 08:41:48 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has denied Oleg Smirnov
<oleg_smirnov at hotmail.com>'s request for review:
Bug 79273: HTML Comments after </body> are placed at the bottom of the <body>
contents
https://bugs.webkit.org/show_bug.cgi?id=79273

Attachment 194545: Patch
https://bugs.webkit.org/attachment.cgi?id=194545&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194545&action=review


> Source/WebCore/ChangeLog:8
> +	   Skip inserting of content comments to innerHTML return value.

We need a layout test for this. See
http://www.webkit.org/quality/testwriting.html
r- due to the lack of tests.


More information about the webkit-reviews mailing list