[webkit-reviews] review granted: [Bug 113034] [GTK] Include the right GL header for GLES2 : [Attachment 194494] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 22 07:08:22 PDT 2013


Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 113034: [GTK] Include the right GL header for GLES2
https://bugs.webkit.org/show_bug.cgi?id=113034

Attachment 194494: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=194494&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
Do you mind moving the conditional includes to separate block below from the
main section? For instance:

#include "stuff.h"
#include <a.h>
#include <b.h>

#if USE(OPENGL_ES_2)
#include <c.h>
#else
#include <d.h>
#endif


More information about the webkit-reviews mailing list