[webkit-reviews] review granted: [Bug 110717] [EFL] Consolidate defaults for feature flags : [Attachment 193455] move the computation out to a macro

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 21 21:23:54 PDT 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Laszlo Gombos
<laszlo.gombos at webkit.org>'s request for review:
Bug 110717: [EFL] Consolidate defaults for feature flags
https://bugs.webkit.org/show_bug.cgi?id=110717

Attachment 193455: move the computation out to a macro
https://bugs.webkit.org/attachment.cgi?id=193455&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
LGTM. I hope remained feature definitions are going to be moved to from
OptionEfl.cmake to FeatureDefinesEfl.h.


More information about the webkit-reviews mailing list