[webkit-reviews] review canceled: [Bug 112992] document.activeElement should not point elements with display:none : [Attachment 194418] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 21 20:39:45 PDT 2013


Kent Tamura <tkent at chromium.org> has canceled Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 112992: document.activeElement should not point elements with display:none
https://bugs.webkit.org/show_bug.cgi?id=112992

Attachment 194418: Patch
https://bugs.webkit.org/attachment.cgi?id=194418&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194418&action=review


>> Source/WebCore/dom/Document.cpp:1904
>> +
> 
> Should we do this here or do the check on Document::activeElement()?
> My concerns are:
> - Whether this is a "catch all" location.
> - If we want to restore focus after setting display property back to
something other than "none".

> - If we want to restore focus after setting display property back to
something other than "none".

good point.  I confirmed IE, Firefox, and Opera kept focus state when we set
display:none then display:block.  This patch is not compatible.


More information about the webkit-reviews mailing list