[webkit-reviews] review granted: [Bug 112989] [wk2] Page Overlays: Don't create backing store until the client asks us to paint : [Attachment 194411] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 112989: [wk2] Page Overlays: Don't create backing store until the client
asks us to paint
https://bugs.webkit.org/show_bug.cgi?id=112989

Attachment 194411: patch
https://bugs.webkit.org/attachment.cgi?id=194411&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194411&action=review


> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:419
>      for (PageOverlayLayerMap::iterator it = m_pageOverlayLayers.begin(); it
!= end; ++it)
> -	   it->value->setSize(viewSize);
> +	   if (it->value->drawsContent())
> +	       it->value->setSize(viewSize);

Please add braces around the for loop and put it->value in its own variable.