[webkit-reviews] review denied: [Bug 112713] [chromium] Support Quota API in Worker in WebKit API : [Attachment 194357] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 21 17:41:47 PDT 2013


David Levin <levin at chromium.org> has denied Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 112713: [chromium] Support Quota API in Worker in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=112713

Attachment 194357: Patch
https://bugs.webkit.org/attachment.cgi?id=194357&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194357&action=review


>> Source/WebKit/chromium/src/WorkerStorageQuotaCallbacksBridge.cpp:46
>> +// FIXME: This should be generalized with classes like
MainThreadFileSystemCallbacks
> 
> Can we update this FIXME to:
> 
> // FIXME: Replace WebFrame parameter in queryStorageUsageAndQuota() with
WebString and move the method to Platform so that we can remove all these
complexity for Worker.

+1

> Source/WebKit/chromium/src/WorkerStorageQuotaCallbacksBridge.cpp:50
> +    // Callbacks are self-destructed and we always return leaked pointer
here.

It might be better to explain that the class is destructed in the callbacks
"did*. See the other comment below.

> Source/WebKit/chromium/src/WorkerStorageQuotaCallbacksBridge.cpp:63
> +	   m_bridge->didQueryStorageUsageAndQuotaOnMainThread(usageInBytes,
quotaInBytes, m_mode);

delete this;

> Source/WebKit/chromium/src/WorkerStorageQuotaCallbacksBridge.cpp:68
> +	   m_bridge->didFailOnMainThread(error, m_mode);

delete this;


More information about the webkit-reviews mailing list