[webkit-reviews] review requested: [Bug 112811] REGRESSION (r146239): Reproducible crash in WebCore::DocumentLoader::responseReceived : [Attachment 194390] Attempt to prevent identifier of 0

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 112811: REGRESSION (r146239): Reproducible crash in
WebCore::DocumentLoader::responseReceived
https://bugs.webkit.org/show_bug.cgi?id=112811

Attachment 194390: Attempt to prevent identifier of 0
https://bugs.webkit.org/attachment.cgi?id=194390&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Ok, I *think* this does the job.  In a normal load, we set a main resource's
identifier on the CachedRawResource when we receive a response, but we don't do
so in the revalidation case.  Since a resource can't have multiple
revalidations at once and can't be revalidated if it's still loading, it should
be safe to copy the identifier to the revalidated resource, even though that
overwrites its old identifier.