[webkit-reviews] review granted: [Bug 110375] Add client callbacks to notify of changes of associated form controls : [Attachment 194347] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Dane Walllinga
<dgwallinga at chromium.org>'s request for review:
Bug 110375: Add client callbacks to notify of changes of associated form
controls
https://bugs.webkit.org/show_bug.cgi?id=110375

Attachment 194347: Patch
https://bugs.webkit.org/attachment.cgi?id=194347&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194347&action=review


> Source/WebKit/chromium/src/ChromeClientImpl.cpp:1148
> +void ChromeClientImpl::didAssociateFormControls(Vector<Element*>& elements)

This should certainly be const Vector<Element*>&. cq- because of this.

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:1156
> +    Vector<Element*>::iterator end = elements.end();
> +    for (Vector<Element*>::iterator it = elements.begin(); it != end; ++it,
++i)
> +	   elementVector[i] = WebNode(*it);

We prefer indexing over iterators for vectors.
See http://www.webkit.org/coding/coding-style.html#punctuation