[webkit-reviews] review denied: [Bug 112891] [Qt] Remove Qt specific WorkQueueItem definitions. : [Attachment 194210] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 112891: [Qt] Remove Qt specific WorkQueueItem definitions.
https://bugs.webkit.org/show_bug.cgi?id=112891

Attachment 194210: Patch
https://bugs.webkit.org/attachment.cgi?id=194210&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194210&action=review


Looks like your lean the JSStringRef?

> Source/JavaScriptCore/API/JSStringRefQt.cpp:42
> +JSStringRef JSStringCreateWithQString(const QString& str)

Should this return a JSRetainPtr to avoid any mistake?