[webkit-reviews] review denied: [Bug 112910] Implement the DeviceAcceleration and DeviceRotationRate IDL objects : [Attachment 194259] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied  review:
Bug 112910: Implement the DeviceAcceleration and DeviceRotationRate IDL objects
https://bugs.webkit.org/show_bug.cgi?id=112910

Attachment 194259: Patch
https://bugs.webkit.org/attachment.cgi?id=194259&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194259&action=review


This looks great, but I think there's a use-after-free issue here.

> Source/WebCore/dom/DeviceAcceleration.h:48
> +    const DeviceMotionData::Acceleration* m_acceleration;

What's the ownership relationship between these two objects? 
DeviceAcceleration is RefCounted, so there's a risk that it might outlive
m_acceleration.

> Source/WebCore/dom/DeviceAcceleration.idl:30
> +    readonly attribute double? x;

Nice!

> Source/WebCore/dom/DeviceRotationRate.h:48
> +    const DeviceMotionData::RotationRate* m_rotationRate;

Same problem here.