[webkit-reviews] review granted: [Bug 112856] Objective-C API: wrapperClass holds a static JSClassRef, which causes JSGlobalObjects to leak : [Attachment 194273] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 112856: Objective-C API: wrapperClass holds a static JSClassRef, which
causes JSGlobalObjects to leak
https://bugs.webkit.org/show_bug.cgi?id=112856

Attachment 194273: Patch
https://bugs.webkit.org/attachment.cgi?id=194273&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194273&action=review


r=me

> Source/JavaScriptCore/API/JSAPIWrapperObject.mm:85
> +    m_wrappedObject = [static_cast<id>(wrappedObject) retain];

Let's make m_wrappedObject a RetainPtr. This can be a follow-up patch.