[webkit-reviews] review granted: [Bug 112922] Floor cell widths in AutoTableLayout::recalcColumn : [Attachment 194284] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 112922: Floor cell widths in AutoTableLayout::recalcColumn
https://bugs.webkit.org/show_bug.cgi?id=112922

Attachment 194284: Patch
https://bugs.webkit.org/attachment.cgi?id=194284&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194284&action=review


> Source/WebCore/ChangeLog:11
> +	   Table cells widths are floored to ensure even distribution of
available
> +	   space across columns. The code path that computes the width of the
> +	   _table_ failed to take this into account and thus can over report
the
> +	   total width of the table.

Whoops!! Thanks Emil :)

> LayoutTests/ChangeLog:11
> +	   * fast/sub-pixel/table-with-subpixel-cell-size-expected.html: Added.

> +	   * fast/sub-pixel/table-with-subpixel-cell-size.html: Added.

Why no entries for the the changed expectations? Also, I presume this will
trigger failures on other platforms as well?

>
LayoutTests/platform/chromium-win/tables/mozilla_expected_failures/bugs/bug8931
5-expected.txt:10
>	   RenderTable {TABLE} at (67,20) size 474x4525

Man this output sucks :(