[webkit-reviews] review granted: [Bug 111513] Create a script to import W3C tests : [Attachment 194275] new patch to incorporate feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 21 09:01:23 PDT 2013


Rebecca Hauck <rhauck at adobe.com> has granted  review:
Bug 111513: Create a script to import W3C tests
https://bugs.webkit.org/show_bug.cgi?id=111513

Attachment 194275: new patch to incorporate feedback
https://bugs.webkit.org/attachment.cgi?id=194275&action=review

------- Additional Comments from Rebecca Hauck <rhauck at adobe.com>
Ok, this has been completely revised to incorporate all the feedback here -
split into modules + classes, unit tests added.  There is no longer a manifest
file and no longer a manual step. The vendor prefixing is now handled by
loading the latest list from the Webkit source and looking for those properties
in the tests. The parsing and conversion code has tests, but I probably still
need to add tests for the actual import code that needs real directories of W3C
tests to work. I wasn't sure how to do that and would like the reviewer's
input. There is at least one test for importing a directory with no tests in
it.


More information about the webkit-reviews mailing list