[webkit-reviews] review granted: [Bug 112910] Implement the DeviceAcceleration and DeviceRotationRate IDL objects : [Attachment 194259] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Peter Beverloo
<peter at chromium.org>'s request for review:
Bug 112910: Implement the DeviceAcceleration and DeviceRotationRate IDL objects
https://bugs.webkit.org/show_bug.cgi?id=112910

Attachment 194259: Patch
https://bugs.webkit.org/attachment.cgi?id=194259&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194259&action=review


Looks OK. Thanks for removing a bunch of custom bindings.

> Source/WebCore/dom/DeviceMotionEvent.cpp:69
> +    if (!m_acceleration.get())

Nit: .get() is not needed.

> Source/WebCore/dom/DeviceMotionEvent.cpp:80
> +    if (!m_accelerationIncludingGravity.get())

Ditto.

> Source/WebCore/dom/DeviceMotionEvent.cpp:91
> +    if (!m_rotationRate.get())

Ditto.