[webkit-reviews] review requested: [Bug 112887] [Chromium] Add page cache support to FrameLoaderClientImpl : [Attachment 194225] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 21 04:40:49 PDT 2013


Christophe Dumez <dchris at gmail.com> has asked  for review:
Bug 112887: [Chromium] Add page cache support to FrameLoaderClientImpl
https://bugs.webkit.org/show_bug.cgi?id=112887

Attachment 194225: Patch
https://bugs.webkit.org/attachment.cgi?id=194225&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
I'm hoping someone who knows this code well can shade some light on the data
source redirect chain. I'm not quite sure how to it should be handled for
frames restored from the page cache. They have a redirect chain when the
provisional load starts, which is unexpected (and asserts). For now, I'm simply
clearing the redirect chain in dispatchDidStartProvisionalLoad().


More information about the webkit-reviews mailing list