[webkit-reviews] review granted: [Bug 112877] Refactoring: Reorganize datetime field element parameters : [Attachment 194185] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Kunihiko Sakamoto
<ksakamoto at chromium.org>'s request for review:
Bug 112877: Refactoring: Reorganize datetime field element parameters
https://bugs.webkit.org/show_bug.cgi?id=112877

Attachment 194185: Patch
https://bugs.webkit.org/attachment.cgi?id=194185&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194185&action=review


Almost ok

> Source/WebCore/html/shadow/DateTimeEditElement.cpp:71
> +    DateTimeNumericFieldElement::Step createStep(const Decimal&
msPerFieldUnit, const Decimal& msPerFieldSize) const;

Because almost all of real arguments for createStep are WTF::msPerFoo, we had
better make the argument types double, and convert them to Decimal in
createStep.