[webkit-reviews] review denied: [Bug 112873] Remove ValueCheck system : [Attachment 194181] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 23:19:18 PDT 2013


Alexey Proskuryakov <ap at webkit.org> has denied	review:
Bug 112873: Remove ValueCheck system
https://bugs.webkit.org/show_bug.cgi?id=112873

Attachment 194181: Patch
https://bugs.webkit.org/attachment.cgi?id=194181&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
The work in bug 112831 is not nearly useful enough to validate removing
security checks that proved helpful in the past. Is there a stronger reason to
do this?

I'm not sure what you mean when saying that fastMalloc isn't used everywhere.
Are you talking about ports using a malloc that doesn't have introspection
capabilities? Or about some parts of WebCore?

I find it unimpressive that the patch got immediately cq+'ed without any
discussion outside business hours.


More information about the webkit-reviews mailing list