[webkit-reviews] review denied: [Bug 17022] Add APNG support : [Attachment 192943] v01_apng_webkit.patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Max Stepin <maxstepin at yahoo.com>'s
request for review:
Bug 17022: Add APNG support
https://bugs.webkit.org/show_bug.cgi?id=17022

Attachment 192943: v01_apng_webkit.patch
https://bugs.webkit.org/attachment.cgi?id=192943&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192943&action=review


We shouldn't land this patch unless one or more WebKit work wishes to enable
this code.  If we're going to accept this patch, we'll also need a number of
tests.

> Source/WebCore/ChangeLog:3
> +	   [GTK] [wx] Add APNG support

This issue is not specific to the GTK and wx ports, so it shouldn't have these
prefixes.

> Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:108
> +#ifdef PNG_APNG_SUPPORTED

This should read:

#if ENABLE(APNG)

Also, all the code introduced to support APNG should be behind this compile
flag.

> Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:241
> +    , m_frameIsHidden(false)
> +    , m_curFrame(0)
> +    , m_loopsCount(0)
> +    , m_delayNum(1)
> +    , m_delayDen(1)
> +    , m_dispose(0)
> +    , m_blend(0)

All this state as well.