[webkit-reviews] review granted: [Bug 112828] [skia] feConvolveMatrix should use accelerated path : [Attachment 194105] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 112828: [skia] feConvolveMatrix should use accelerated path
https://bugs.webkit.org/show_bug.cgi?id=112828

Attachment 194105: Patch
https://bugs.webkit.org/attachment.cgi?id=194105&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194105&action=review


Hm, ok. I don't think I understand this very well but seems reasonable.

> Source/WebCore/platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp:43
> +    case WebCore::EDGEMODE_UNKNOWN:
> +    case WebCore::EDGEMODE_DUPLICATE:
> +    default:
> +	   return SkMatrixConvolutionImageFilter::kClamp_TileMode;

this looks weird. why not do

switch () {
case ..._WRAP:
   return ...;
case ..._NONE:
   return ...;
default:
   return ....;
}

?