[webkit-reviews] review denied: [Bug 112582] [CoordinatedGraphics] serviceScriptedAnimations expects time in seconds : [Attachment 194124] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 112582: [CoordinatedGraphics] serviceScriptedAnimations expects time in
seconds
https://bugs.webkit.org/show_bug.cgi?id=112582

Attachment 194124: Patch
https://bugs.webkit.org/attachment.cgi?id=194124&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194124&action=review


No problem with the change, but the test needs work.

>
LayoutTests/fast/animation/script-tests/request-animation-frame-time-unit.js:3
> +var toleranceInMs = 50;

Why does this need to be global?

50 seems huge.

>
LayoutTests/fast/animation/script-tests/request-animation-frame-time-unit.js:7
> +var callbackTimeRef = 0;
> +var timeRefInMs = 0;

Ditto.

>
LayoutTests/fast/animation/script-tests/request-animation-frame-time-unit.js:18

> +    if (window.testRunner)
> +	   testRunner.display();

I am surprised this is inside the callback and not in the test setup.

>
LayoutTests/fast/animation/script-tests/request-animation-frame-time-unit.js:26

> +setTimeout(function() {
> +    shouldBeTrue("isTimeUnitInMs");
> +}, 250);

Nope, this should be done from the second callback of
window.requestAnimationFrame.
With this, you would introduce a mandatory 250 ms delay for this test, while it
could be ~34ms.

>
LayoutTests/fast/animation/script-tests/request-animation-frame-time-unit.js:29

> +if (window.testRunner)
> +    testRunner.waitUntilDone();

js-tests have a variable for this, you should not do it manually.

>
LayoutTests/fast/animation/script-tests/request-animation-frame-time-unit.js:35

> +setTimeout(function() {
> +    isSuccessfullyParsed();
> +    if (window.testRunner)
> +	   testRunner.notifyDone();
> +}, 300);

Wait what?