[webkit-reviews] review granted: [Bug 70634] Mark GraphicsLayers as opaque when possible : [Attachment 193895] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 70634: Mark GraphicsLayers as opaque when possible
https://bugs.webkit.org/show_bug.cgi?id=70634

Attachment 193895: Patch
https://bugs.webkit.org/attachment.cgi?id=193895&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193895&action=review


> Source/WebCore/rendering/RenderBox.cpp:95
> +static bool skipBodyBackground(const RenderBox* bodyElementRenderer)

This function name is unclear. Skip for what?

> Source/WebCore/rendering/RenderLayer.cpp:5539
> +    // It is somehow getting triggered during style update.

The "somehow" is a bit mysterious. You should investigate and file a bug.