[webkit-reviews] review granted: [Bug 112845] "" + x where x is not a string should be optimized by the DFG to some manner of ToString conversion : [Attachment 194127] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 112845: "" + x where x is not a string should be optimized by the DFG to
some manner of ToString conversion
https://bugs.webkit.org/show_bug.cgi?id=112845

Attachment 194127: the patch
https://bugs.webkit.org/attachment.cgi?id=194127&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194127&action=review


r=me

> Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp:46
> +    if (isObjectSpeculation(type)) {
> +	   // I'd love to fold this case into the case below, but I can't,
because
> +	   // removing SpecObject from something that only has an object
> +	   // prediction and nothing else means we have an ill-formed
SpeculatedType
> +	   // (strong predict-none). This should be killed once we remove all
traces
> +	   // of static (aka weak) predictions.
> +	   return type;
> +    }

According to this comment, we can now delete this branch.