[webkit-reviews] review granted: [Bug 112642] Assertion in LegacyWebArchive::create() in editing tests : [Attachment 194116] Fix that

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 112642: Assertion in LegacyWebArchive::create() in editing tests
https://bugs.webkit.org/show_bug.cgi?id=112642

Attachment 194116: Fix that
https://bugs.webkit.org/attachment.cgi?id=194116&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194116&action=review


Please fix the typo.

> Source/WebCore/ChangeLog:8
> +	   It's possible for clipboard to be overriden between the time we
retrieve clipboard types and the time

typo overwritten.

> Source/WebCore/platform/mac/PasteboardMac.mm:476
> +	   NSString *markupString = [[NSString alloc]
initWithData:[mainResource->data()->createNSData() autorelease]
encoding:NSUTF8StringEncoding];

You could have used RetainPtr here and avoid calling release.