[webkit-reviews] review granted: [Bug 112832] Objective-C API: Fix over-releasing in allocateConstructorAndPrototypeWithSuperClassInfo: : [Attachment 194111] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 112832: Objective-C API: Fix over-releasing in
allocateConstructorAndPrototypeWithSuperClassInfo:
https://bugs.webkit.org/show_bug.cgi?id=112832

Attachment 194111: Patch
https://bugs.webkit.org/attachment.cgi?id=194111&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194111&action=review


r=me

> Source/JavaScriptCore/ChangeLog:15
> +	   (createObjectWithCustomBrand): We no longer alloc here. We instead
call the JSValue valueWithValue class method,

"create" is a term of art for returning a +1 retained object. Since you're
changing this function to return an autoreleased object, you should rename it
to "objectWithCustomBrand".