[webkit-reviews] review granted: [Bug 112773] Move repaint methods from RenderObject to RenderBox : [Attachment 193978] fix mac build
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 20 09:14:05 PDT 2013
Julien Chaffraix <jchaffraix at webkit.org> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 112773: Move repaint methods from RenderObject to RenderBox
https://bugs.webkit.org/show_bug.cgi?id=112773
Attachment 193978: fix mac build
https://bugs.webkit.org/attachment.cgi?id=193978&action=review
------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193978&action=review
> Source/WebCore/rendering/RenderBox.h:381
> + virtual void repaintOverhangingFloats(bool) { };
We should switch that function to using an enum or at least keep the parameter
name. Not providing it makes it hard to see what this bool is supposed to be.
More information about the webkit-reviews
mailing list