[webkit-reviews] review granted: [Bug 112496] Web Inspector: Flame Chart. Provide Overview pane for better user expirience : [Attachment 194069] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 09:05:44 PDT 2013


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 112496: Web Inspector: Flame Chart. Provide Overview pane for better user
expirience
https://bugs.webkit.org/show_bug.cgi?id=112496

Attachment 194069: Patch
https://bugs.webkit.org/attachment.cgi?id=194069&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194069&action=review


> Source/WebCore/ChangeLog:13
> +	   Drive by change: fix the drag window & drag resizer mechancs for the
case when parent element has zero offsetLeft.

mechancs ?

> Source/WebCore/inspector/front-end/FlameChart.js:62
> +    this._canvas.onmousemove = this._onMouseMove.bind(this);

Why not addEventListener?


More information about the webkit-reviews mailing list