[webkit-reviews] review granted: [Bug 112679] [Qt][WK2] Clean up sanity checks related to gesture recognition : [Attachment 193779] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 06:01:27 PDT 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 112679: [Qt][WK2] Clean up sanity checks related to gesture recognition
https://bugs.webkit.org/show_bug.cgi?id=112679

Attachment 193779: Patch
https://bugs.webkit.org/attachment.cgi?id=193779&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193779&action=review


>> Source/WebKit2/UIProcess/qt/PageViewportControllerClientQt.cpp:166
>> +	ASSERT(!m_viewportItem->isDragging() && !(m_pinchStartScale > 0));
> 
> You can split this into 2 assertions.

r=me if you fix this.


More information about the webkit-reviews mailing list