[webkit-reviews] review granted: [Bug 112114] [EFL] Disable REQUEST_ANIMATION_FRAME_TIMER to render a new animation frame. : [Attachment 193997] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted JungJik Lee
<jungjik.lee at samsung.com>'s request for review:
Bug 112114: [EFL] Disable REQUEST_ANIMATION_FRAME_TIMER to render a new
animation frame.
https://bugs.webkit.org/show_bug.cgi?id=112114

Attachment 193997: Patch
https://bugs.webkit.org/attachment.cgi?id=193997&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193997&action=review


> Source/WTF/ChangeLog:7
> +

Now please try to keep the line length similar!

> Source/WTF/ChangeLog:8
> +	   The issue is that if the animation starts from out of keepRects,

outside of the area covered by keepRect, the web process does not...

> Source/WTF/ChangeLog:9
> +	   WebProcess does not create tiles of the animation layer and the
layer moves with having no tiles.

moves without having any tiles

> Source/WTF/ChangeLog:10
> +	   To fix this issue, CoordinatedLayerHost should call
scheduleLayerFlush to create new tiles 

In order to fix this issue ... must call

> Source/WTF/ChangeLog:11
> +	   when the layer is coming inside keepRect.

when the layer enters the area covered by keepRect.

> Source/WTF/ChangeLog:13
> +	   We can tie scripted animations with synchronizing the layer 

synchronization of

> Source/WTF/ChangeLog:14
> +	   and that already has been implemented by r123786 in QT Port.

implemented in ... by the Qt port.