[webkit-reviews] review granted: [Bug 112780] DFG implementation of op_strcat should inline rope allocations : [Attachment 193996] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 01:32:50 PDT 2013


Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 112780: DFG implementation of op_strcat should inline rope allocations
https://bugs.webkit.org/show_bug.cgi?id=112780

Attachment 193996: the patch
https://bugs.webkit.org/attachment.cgi?id=193996&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193996&action=review


> Source/JavaScriptCore/dfg/DFGOperations.cpp:1576
> +    JSGlobalData& globalData = exec->globalData();

#if CPU(X86)
RELEASE_ASSERT_NOT_REACHED();
#endif 
?


More information about the webkit-reviews mailing list