[webkit-reviews] review denied: [Bug 112371] Web Inspector: Paint rectangles shown on hover over Timeline's paint records occasionally have wrong offsets : [Attachment 193874] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 20 00:43:40 PDT 2013


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 112371: Web Inspector: Paint rectangles shown on hover over Timeline's
paint records occasionally have wrong offsets
https://bugs.webkit.org/show_bug.cgi?id=112371

Attachment 193874: Patch
https://bugs.webkit.org/attachment.cgi?id=193874&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193874&action=review


> Source/WebCore/inspector/InspectorInstrumentation.cpp:538
> +void InspectorInstrumentation::didPaintImpl(InstrumentingAgents* 
instrumentingAgents, Frame* frame, GraphicsContext* context, const LayoutRect&
rect)

Extra space here.

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:304
> +    LayoutRect rectInRootCoordinates =
frame->view()->contentsToRootView(pixelSnappedIntRect(rect));

So that's the actual fix? Looks like two changes in one patch to me.


More information about the webkit-reviews mailing list