[webkit-reviews] review denied: [Bug 112114] [EFL] Disable REQUEST_ANIMATION_FRAME_TIMER to render a new animation frame. : [Attachment 193981] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 19 23:37:08 PDT 2013


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied JungJik Lee
<jungjik.lee at samsung.com>'s request for review:
Bug 112114: [EFL] Disable REQUEST_ANIMATION_FRAME_TIMER to render a new
animation frame.
https://bugs.webkit.org/show_bug.cgi?id=112114

Attachment 193981: Patch
https://bugs.webkit.org/attachment.cgi?id=193981&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193981&action=review


> Source/WTF/ChangeLog:13
> +
> +	   EFL WK2 port uses WebChromeClient as same as QT port for scripted
animation.
> +	   While the layer has the active animation, CoordinatedLayerHost needs
to schedule animations
> +	   by servicing of scripted animations.
> +
> +	   The testing is covered by
ManualTests/animation/transition-on-and-offscreen-animation.html
> +

You don't explain at all why that solves it.

What, why, how are good ingredients of a changelog


More information about the webkit-reviews mailing list