[webkit-reviews] review granted: [Bug 104969] Merge MainResourceLoader into DocumentLoader : [Attachment 193949] Finish the merger

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 19 20:55:09 PDT 2013


Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 104969: Merge MainResourceLoader into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=104969

Attachment 193949: Finish the merger
https://bugs.webkit.org/attachment.cgi?id=193949&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193949&action=review


Amazing.

> Source/WebCore/loader/DocumentLoader.cpp:1390
> +    DEFINE_STATIC_LOCAL(ResourceLoaderOptions, mainResourceLoadOptions,
> +	   (SendCallbacks, SniffContent, BufferData, AllowStoredCredentials,
AskClientForCrossOriginCredentials, SkipSecurityCheck));

I'm surprised we use a static here.  This is just a struct...


More information about the webkit-reviews mailing list