[webkit-reviews] review granted: [Bug 112727] [GTK] Add WebCoreHTML to the gyp build : [Attachment 193883] Patch

[bugzilla-daemon at webkit.org]

Nico Weber <thakis at chromium.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 112727: [GTK] Add WebCoreHTML to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112727

Attachment 193883: Patch
https://bugs.webkit.org/attachment.cgi?id=193883&action=review

------- Additional Comments from Nico Weber <thakis at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193883&action=review


Makes sense.

> Source/WebCore/WebCore.gyp/WebCoreGTK.gyp:921
> +	 'type': 'none',

Does linking to a none target that depends on two static_library targets do the
right thing? (i.e. link in the two static libraries)