[webkit-reviews] review granted: [Bug 112719] Cache a pointer to V8DOMActivityLogger in PerContextData : [Attachment 193953] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Ankur Taly <ataly at google.com>'s
request for review:
Bug 112719: Cache a pointer to V8DOMActivityLogger in PerContextData
https://bugs.webkit.org/show_bug.cgi?id=112719

Attachment 193953: Patch
https://bugs.webkit.org/attachment.cgi?id=193953&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193953&action=review


Looks OK

> Source/WebCore/ChangeLog:16
> +	   Cache a pointer to V8DOMActivityLogger in PerContextData.
> +	   Adds a data member (and getter, setter methods) to V8PerContextData
> +	   that holds a pointer to a V8DOMActivityLogger. This member is set
while
> +	   initializing the context for a V8DOMWindowShell. Ownership of the
pointer
> +	   is still retained by the HashMap in DOMWrapperWorld.
> +	   As a result of this patch, subsequent patches that will implement
logging
> +	   for DOM API access (See bug 107207) will be able to obtain a
reference to
> +	   the logger directly from PerContextData. This will benefit
performance as it
> +	   will be faster than looking up the logger in the HashMap in
DOMWrapperWorld.
> +	   https://bugs.webkit.org/show_bug.cgi?id=112719
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   There are no new tests as there is no change in behavior.

Nit: In WebKit we write a bug title (which should be in one line), a bug URL, a
bug description, and a test, in this order. Please fix it before landing.

> Source/WebCore/bindings/v8/V8PerContextData.h:128
> +    V8DOMActivityLogger* m_activityLogger;

Would you add a comment about the lifetime?