[webkit-reviews] review granted: [Bug 112751] [chromium] move WebThemeEngine implementations to TestRunner library : [Attachment 193946] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 112751: [chromium] move WebThemeEngine implementations to TestRunner
library
https://bugs.webkit.org/show_bug.cgi?id=112751

Attachment 193946: Patch
https://bugs.webkit.org/attachment.cgi?id=193946&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193946&action=review


rs=me

> Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:90
> +    std::auto_ptr<WebKit::WebThemeEngine> m_themeEngine;

Isn't this the bad case for auto_ptr?  Rather than forward declaring
WebThemeEngine, we should probably #include it.