[webkit-reviews] review denied: [Bug 112483] [wip] [chromium] Remove the WebVideoFrame, WebVideoFrameProvider, WebStreamTextureClient, and WebVideoLayer classes. : [Attachment 193701] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 112483: [wip] [chromium] Remove the WebVideoFrame, WebVideoFrameProvider,
WebStreamTextureClient, and WebVideoLayer classes.
https://bugs.webkit.org/show_bug.cgi?id=112483

Attachment 193701: Patch
https://bugs.webkit.org/attachment.cgi?id=193701&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I really like the direction this is going on. One small change I'd like to see
as we discussed on IRC is moving the ownership of the WebLayer exclusively to
the WebMediaPlayer and exposing only a non-owning pointer to
WebMediaPlayerClientImpl.  It looks like the way that would be most consistent
with how plugins work would be to add

  virtual void setWebLayer(WebLayer*)

to WebMediaPlayerClient and in the implementation figure out whether that means
to register/unregister the layer and then store a (raw, weak) pointer in a
member on WebMediaPlayerClientImpl.

(r- for now to get out of the queue, but otherwise this looks super nice)