[webkit-reviews] review granted: [Bug 112734] Refactored script content removal in the fragment parser for clarity and speed : [Attachment 193913] Patch

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 112734: Refactored script content removal in the fragment parser for
clarity and speed
https://bugs.webkit.org/show_bug.cgi?id=112734

Attachment 193913: Patch
https://bugs.webkit.org/attachment.cgi?id=193913&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193913&action=review


Looks good to me. This is a great improvement!

> Source/WebCore/dom/Element.cpp:-1034
> -void Element::parserSetAttributes(const Vector<Attribute>& attributeVector,
FragmentScriptingPermission scriptingPermission)

This is very clever!

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:-703
> -static inline void handleNamespaceAttributes(Vector<Attribute, 8>&
prefixedAttributes, const xmlChar** libxmlNamespaces, int nb_namespaces,
ExceptionCode& ec)

Why did you remove the 8?