[webkit-reviews] review granted: [Bug 112736] GenerateHashValue should be usable outside CodeGeneratorJS.pm : [Attachment 193897] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 19 12:47:10 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 112736: GenerateHashValue should be usable outside CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112736

Attachment 193897: Patch
https://bugs.webkit.org/attachment.cgi?id=193897&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
No problem with this.
But this Perl GenerateHashValue should die. We should have a compile time Hash
function in C++ instead.


More information about the webkit-reviews mailing list