[webkit-reviews] review granted: [Bug 112681] CSP 1.1: Stub out SecurityPolicyViolationEvent interface. : [Attachment 193867] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 112681: CSP 1.1: Stub out SecurityPolicyViolationEvent interface.
https://bugs.webkit.org/show_bug.cgi?id=112681

Attachment 193867: Patch
https://bugs.webkit.org/attachment.cgi?id=193867&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193867&action=review


> Source/WebCore/dom/SecurityPolicyViolationEvent.h:69
> +    virtual const AtomicString& interfaceName() const { return
eventNames().interfaceForSecurityPolicyViolationEvent; }

Does this whole header need a CSP_NEXT ifdef?

> Source/WebCore/dom/SecurityPolicyViolationEvent.h:76
> +    SecurityPolicyViolationEvent(const String& documentURI, const String&
referrer, const String& blockedURI, const String& violatedDirective, const
String& effectiveDirective, const String& originalPolicy, const String&
sourceURL, int lineNumber)

This function now has no callers.