[webkit-reviews] review denied: [Bug 112543] Web Inspector: [Network] Refactoring before adding more columns. : [Attachment 193508] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 19 09:55:13 PDT 2013
Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 112543: Web Inspector: [Network] Refactoring before adding more columns.
https://bugs.webkit.org/show_bug.cgi?id=112543
Attachment 193508: Patch
https://bugs.webkit.org/attachment.cgi?id=193508&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193508&action=review
This refactoring seems to be a bit too massive to me. Is there a way it gets
split into parts?
> Source/WebCore/inspector/front-end/NetworkPanel.js:2111
> + this._refreshNameCell(this._cells["name"], request);
Why passing request into all of them?
More information about the webkit-reviews
mailing list