[webkit-reviews] review granted: [Bug 112670] FeatureObserver: Measure X-Frame-Options usage. : [Attachment 193759] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 112670: FeatureObserver: Measure X-Frame-Options usage.
https://bugs.webkit.org/show_bug.cgi?id=112670

Attachment 193759: Patch
https://bugs.webkit.org/attachment.cgi?id=193759&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193759&action=review


> Source/WebCore/page/Frame.cpp:1051
> +bool Frame::isSameOriginWithAllAncestors() const

This function implies that the "same-origin" relation is symmetric, which isn't
the case.

I'd prefer to line this function into
FrameLoader::shouldInterruptLoadForXFrameOptions.  It's not really a
general-purpose function, and I wouldn't want other code to call it.